Skip to content
  • commit-queue@webkit.org's avatar
    b6950fe5
    Move WebGLErrorsToConsole page setting to window.internals.settings · b6950fe5
    commit-queue@webkit.org authored
    https://bugs.webkit.org/show_bug.cgi?id=107218
    
    Source/WebCore:
    
    Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2013-01-25
    Reviewed by Kenneth Russell.
    
    Define webGLErrorsToConsoleEnabled as true by default. Also,
    WebGLRenderingContext::m_synthesizedErrorsToConsole is true by default
    and can be disabled by settings.
    
    Add a ConsoleDisplayPreference parameter to synthesizeGLError
    (defaults to DisplayInConsole). When called with DontDisplayInConsole,
    an error message will not be displayed (even if
    m_synthesizedErrorsToConsole is true).
    
    Call synthesizeGLError with DontDisplayInConsole in case of synthetic
    context lost.
    
    No new tests: covered by existing tests.
    
    * html/canvas/WebGLRenderingContext.cpp:
    (WebCore):
    (WebCore::WebGLRenderingContext::WebGLRenderingContext):
    (WebCore::WebGLRenderingContext::setupFlags):
    (WebCore::WebGLRenderingContext::validateRenderingState):
    (WebCore::WebGLRenderingContext::loseContextImpl):
    (WebCore::WebGLRenderingContext::synthesizeGLError):
    * html/canvas/WebGLRenderingContext.h:
    * page/Settings.in:
    
    LayoutTests:
    
    Set WebGLErrorsToConsoleEnabled to false for WebGL tests which have
    errors. Some WebGL error messages depend on OpenGL implementations, so
    logging error messages would lead to platform specific output.
    
    Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2013-01-25
    Reviewed by Kenneth Russell.
    
    * fast/canvas/webgl/attrib-location-length-limits.html:
    * fast/canvas/webgl/bad-arguments-test.html:
    * fast/canvas/webgl/buffer-bind-test.html:
    * fast/canvas/webgl/buffer-data-array-buffer.html:
    * fast/canvas/webgl/compressed-tex-image.html:
    * fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias.html:
    * fast/canvas/webgl/context-lost-restored.html:
    * fast/canvas/webgl/context-lost.html:
    * fast/canvas/webgl/draw-arrays-out-of-bounds.html:
    * fast/canvas/webgl/draw-elements-out-of-bounds.html:
    * fast/canvas/webgl/error-reporting.html:
    * fast/canvas/webgl/framebuffer-object-attachment.html:
    * fast/canvas/webgl/framebuffer-test.html:
    * fast/canvas/webgl/get-active-test.html:
    * fast/canvas/webgl/gl-bind-attrib-location-test.html:
    * fast/canvas/webgl/gl-enable-enum-test.html:
    * fast/canvas/webgl/gl-enum-tests.html:
    * fast/canvas/webgl/gl-object-get-calls.html:
    * fast/canvas/webgl/gl-uniform-arrays.html:
    * fast/canvas/webgl/gl-uniformmatrix4fv.html:
    * fast/canvas/webgl/gl-vertexattribpointer.html:
    * fast/canvas/webgl/glsl-conformance.html:
    * fast/canvas/webgl/incorrect-context-object-behaviour.html:
    * fast/canvas/webgl/index-validation-copies-indices.html:
    * fast/canvas/webgl/index-validation-verifies-too-many-indices.html:
    * fast/canvas/webgl/index-validation.html:
    * fast/canvas/webgl/invalid-passed-params.html:
    * fast/canvas/webgl/null-object-behaviour.html:
    * fast/canvas/webgl/object-deletion-behaviour.html:
    * fast/canvas/webgl/program-test.html:
    * fast/canvas/webgl/read-pixels-pack-alignment.html:
    * fast/canvas/webgl/read-pixels-test.html:
    * fast/canvas/webgl/script-tests/texImageTest.js:
    * fast/canvas/webgl/shader-deleted-by-accessor.html:
    * fast/canvas/webgl/shader-precision-format.html:
    * fast/canvas/webgl/tex-input-validation.html:
    * fast/canvas/webgl/tex-sub-image-2d-bad-args.html:
    * fast/canvas/webgl/texture-complete.html:
    * fast/canvas/webgl/texture-npot.html:
    * fast/canvas/webgl/type-conversion-test.html:
    * fast/canvas/webgl/uniform-location-length-limits.html:
    * fast/canvas/webgl/uniform-location.html:
    * fast/canvas/webgl/webgl-depth-texture.html:
    * fast/canvas/webgl/webgl-specific.html:
    * fast/canvas/webgl/webgl-texture-binding-preserved.html:
    * inspector/profiler/webgl/webgl-profiler-api-changes.html:
    * inspector/profiler/webgl/webgl-profiler-get-error.html:
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140851 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    b6950fe5
    Move WebGLErrorsToConsole page setting to window.internals.settings
    commit-queue@webkit.org authored
    https://bugs.webkit.org/show_bug.cgi?id=107218
    
    Source/WebCore:
    
    Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2013-01-25
    Reviewed by Kenneth Russell.
    
    Define webGLErrorsToConsoleEnabled as true by default. Also,
    WebGLRenderingContext::m_synthesizedErrorsToConsole is true by default
    and can be disabled by settings.
    
    Add a ConsoleDisplayPreference parameter to synthesizeGLError
    (defaults to DisplayInConsole). When called with DontDisplayInConsole,
    an error message will not be displayed (even if
    m_synthesizedErrorsToConsole is true).
    
    Call synthesizeGLError with DontDisplayInConsole in case of synthetic
    context lost.
    
    No new tests: covered by existing tests.
    
    * html/canvas/WebGLRenderingContext.cpp:
    (WebCore):
    (WebCore::WebGLRenderingContext::WebGLRenderingContext):
    (WebCore::WebGLRenderingContext::setupFlags):
    (WebCore::WebGLRenderingContext::validateRenderingState):
    (WebCore::WebGLRenderingContext::loseContextImpl):
    (WebCore::WebGLRenderingContext::synthesizeGLError):
    * html/canvas/WebGLRenderingContext.h:
    * page/Settings.in:
    
    LayoutTests:
    
    Set WebGLErrorsToConsoleEnabled to false for WebGL tests which have
    errors. Some WebGL error messages depend on OpenGL implementations, so
    logging error messages would lead to platform specific output.
    
    Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2013-01-25
    Reviewed by Kenneth Russell.
    
    * fast/canvas/webgl/attrib-location-length-limits.html:
    * fast/canvas/webgl/bad-arguments-test.html:
    * fast/canvas/webgl/buffer-bind-test.html:
    * fast/canvas/webgl/buffer-data-array-buffer.html:
    * fast/canvas/webgl/compressed-tex-image.html:
    * fast/canvas/webgl/context-attributes-alpha-depth-stencil-antialias.html:
    * fast/canvas/webgl/context-lost-restored.html:
    * fast/canvas/webgl/context-lost.html:
    * fast/canvas/webgl/draw-arrays-out-of-bounds.html:
    * fast/canvas/webgl/draw-elements-out-of-bounds.html:
    * fast/canvas/webgl/error-reporting.html:
    * fast/canvas/webgl/framebuffer-object-attachment.html:
    * fast/canvas/webgl/framebuffer-test.html:
    * fast/canvas/webgl/get-active-test.html:
    * fast/canvas/webgl/gl-bind-attrib-location-test.html:
    * fast/canvas/webgl/gl-enable-enum-test.html:
    * fast/canvas/webgl/gl-enum-tests.html:
    * fast/canvas/webgl/gl-object-get-calls.html:
    * fast/canvas/webgl/gl-uniform-arrays.html:
    * fast/canvas/webgl/gl-uniformmatrix4fv.html:
    * fast/canvas/webgl/gl-vertexattribpointer.html:
    * fast/canvas/webgl/glsl-conformance.html:
    * fast/canvas/webgl/incorrect-context-object-behaviour.html:
    * fast/canvas/webgl/index-validation-copies-indices.html:
    * fast/canvas/webgl/index-validation-verifies-too-many-indices.html:
    * fast/canvas/webgl/index-validation.html:
    * fast/canvas/webgl/invalid-passed-params.html:
    * fast/canvas/webgl/null-object-behaviour.html:
    * fast/canvas/webgl/object-deletion-behaviour.html:
    * fast/canvas/webgl/program-test.html:
    * fast/canvas/webgl/read-pixels-pack-alignment.html:
    * fast/canvas/webgl/read-pixels-test.html:
    * fast/canvas/webgl/script-tests/texImageTest.js:
    * fast/canvas/webgl/shader-deleted-by-accessor.html:
    * fast/canvas/webgl/shader-precision-format.html:
    * fast/canvas/webgl/tex-input-validation.html:
    * fast/canvas/webgl/tex-sub-image-2d-bad-args.html:
    * fast/canvas/webgl/texture-complete.html:
    * fast/canvas/webgl/texture-npot.html:
    * fast/canvas/webgl/type-conversion-test.html:
    * fast/canvas/webgl/uniform-location-length-limits.html:
    * fast/canvas/webgl/uniform-location.html:
    * fast/canvas/webgl/webgl-depth-texture.html:
    * fast/canvas/webgl/webgl-specific.html:
    * fast/canvas/webgl/webgl-texture-binding-preserved.html:
    * inspector/profiler/webgl/webgl-profiler-api-changes.html:
    * inspector/profiler/webgl/webgl-profiler-get-error.html:
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140851 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Loading