Skip to content
  • yurys@chromium.org's avatar
    3495bd3b
    Web Inspector: implement "Reveal in Dominators view" context menu action · 3495bd3b
    yurys@chromium.org authored
    https://bugs.webkit.org/show_bug.cgi?id=86455
    
    Reviewed by Pavel Feldman.
    
    Source/WebCore:
    
    Implemented "Reveal in Dominators view" context menu action for objects
    in the console.
    
    Test: inspector/profiler/heap-snapshot-reveal-in-dominators-view.html
    
    * English.lproj/localizedStrings.js:
    * inspector/front-end/HeapSnapshot.js:
    (WebInspector.HeapSnapshot.prototype._nodeForSnapshotObjectId):
    (WebInspector.HeapSnapshot.prototype.nodeClassName):
    (WebInspector.HeapSnapshot.prototype.dominatorIdsForNode):
    * inspector/front-end/HeapSnapshotDataGrids.js:
    (WebInspector.HeapSnapshotDominatorsDataGrid):
    (WebInspector.HeapSnapshotDominatorsDataGrid.prototype.setDataSource):
    (WebInspector.HeapSnapshotDominatorsDataGrid.prototype.sortingChanged):
    (WebInspector.HeapSnapshotDominatorsDataGrid.prototype.highlightObjectByHeapSnapshotId.didGetDominators):
    (WebInspector.HeapSnapshotDominatorsDataGrid.prototype.highlightObjectByHeapSnapshotId.expandNextDominator):
    (WebInspector.HeapSnapshotDominatorsDataGrid.prototype.highlightObjectByHeapSnapshotId):
    * inspector/front-end/HeapSnapshotGridNodes.js:
    (WebInspector.HeapSnapshotGridNode.prototype.childForPosition):
    (WebInspector.HeapSnapshotGridNode.prototype.expandWithoutPopulate):
    (WebInspector.HeapSnapshotGridNode.prototype._populateChildren.childrenRetrieved):
    (WebInspector.HeapSnapshotGridNode.prototype._populateChildren):
    (WebInspector.HeapSnapshotGridNode.prototype.sort):
    (WebInspector.HeapSnapshotDominatorObjectNode.prototype.retrieveChildBySnapshotObjectId):
    (WebInspector.HeapSnapshotDominatorObjectNode.prototype.retrieveChildBySnapshotObjectId.didGetNodePosition):
    (WebInspector.HeapSnapshotDominatorObjectNode.prototype.retrieveChildBySnapshotObjectId.didPopulateChildren):
    * inspector/front-end/HeapSnapshotProxy.js:
    (WebInspector.HeapSnapshotProxy.prototype.dominatorIdsForNode):
    * inspector/front-end/ProfilesPanel.js:
    (WebInspector.RevealInHeapSnapshotContextMenuProvider.prototype.populateContextMenu.revealInSummaryView):
    (WebInspector.RevealInHeapSnapshotContextMenuProvider.prototype.populateContextMenu.didReceiveHeapObjectId):
    (WebInspector.RevealInHeapSnapshotContextMenuProvider.prototype.populateContextMenu):
    
    LayoutTests:
    
    Test that an object can be revealed in the heap snapshot dominators view
    by its heap snapshot object id.
    
    * inspector/profiler/heap-snapshot-reveal-in-dominators-view-expected.txt: Added.
    * inspector/profiler/heap-snapshot-reveal-in-dominators-view.html: Added.
    * inspector/profiler/heap-snapshot-test.js:
    (initialize_HeapSnapshotTest):
    (initialize_HeapSnapshotTest.):
    * platform/mac/Skipped:
    * platform/qt/Skipped:
    * platform/win/Skipped:
    * platform/wincairo/Skipped:
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117051 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    3495bd3b
    Web Inspector: implement "Reveal in Dominators view" context menu action
    yurys@chromium.org authored
    https://bugs.webkit.org/show_bug.cgi?id=86455
    
    Reviewed by Pavel Feldman.
    
    Source/WebCore:
    
    Implemented "Reveal in Dominators view" context menu action for objects
    in the console.
    
    Test: inspector/profiler/heap-snapshot-reveal-in-dominators-view.html
    
    * English.lproj/localizedStrings.js:
    * inspector/front-end/HeapSnapshot.js:
    (WebInspector.HeapSnapshot.prototype._nodeForSnapshotObjectId):
    (WebInspector.HeapSnapshot.prototype.nodeClassName):
    (WebInspector.HeapSnapshot.prototype.dominatorIdsForNode):
    * inspector/front-end/HeapSnapshotDataGrids.js:
    (WebInspector.HeapSnapshotDominatorsDataGrid):
    (WebInspector.HeapSnapshotDominatorsDataGrid.prototype.setDataSource):
    (WebInspector.HeapSnapshotDominatorsDataGrid.prototype.sortingChanged):
    (WebInspector.HeapSnapshotDominatorsDataGrid.prototype.highlightObjectByHeapSnapshotId.didGetDominators):
    (WebInspector.HeapSnapshotDominatorsDataGrid.prototype.highlightObjectByHeapSnapshotId.expandNextDominator):
    (WebInspector.HeapSnapshotDominatorsDataGrid.prototype.highlightObjectByHeapSnapshotId):
    * inspector/front-end/HeapSnapshotGridNodes.js:
    (WebInspector.HeapSnapshotGridNode.prototype.childForPosition):
    (WebInspector.HeapSnapshotGridNode.prototype.expandWithoutPopulate):
    (WebInspector.HeapSnapshotGridNode.prototype._populateChildren.childrenRetrieved):
    (WebInspector.HeapSnapshotGridNode.prototype._populateChildren):
    (WebInspector.HeapSnapshotGridNode.prototype.sort):
    (WebInspector.HeapSnapshotDominatorObjectNode.prototype.retrieveChildBySnapshotObjectId):
    (WebInspector.HeapSnapshotDominatorObjectNode.prototype.retrieveChildBySnapshotObjectId.didGetNodePosition):
    (WebInspector.HeapSnapshotDominatorObjectNode.prototype.retrieveChildBySnapshotObjectId.didPopulateChildren):
    * inspector/front-end/HeapSnapshotProxy.js:
    (WebInspector.HeapSnapshotProxy.prototype.dominatorIdsForNode):
    * inspector/front-end/ProfilesPanel.js:
    (WebInspector.RevealInHeapSnapshotContextMenuProvider.prototype.populateContextMenu.revealInSummaryView):
    (WebInspector.RevealInHeapSnapshotContextMenuProvider.prototype.populateContextMenu.didReceiveHeapObjectId):
    (WebInspector.RevealInHeapSnapshotContextMenuProvider.prototype.populateContextMenu):
    
    LayoutTests:
    
    Test that an object can be revealed in the heap snapshot dominators view
    by its heap snapshot object id.
    
    * inspector/profiler/heap-snapshot-reveal-in-dominators-view-expected.txt: Added.
    * inspector/profiler/heap-snapshot-reveal-in-dominators-view.html: Added.
    * inspector/profiler/heap-snapshot-test.js:
    (initialize_HeapSnapshotTest):
    (initialize_HeapSnapshotTest.):
    * platform/mac/Skipped:
    * platform/qt/Skipped:
    * platform/win/Skipped:
    * platform/wincairo/Skipped:
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117051 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Loading